Implement bluetooth service caching #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #144 +/- ##
==========================================
- Coverage 70.77% 70.74% -0.03%
==========================================
Files 70 70
Lines 5854 5862 +8
==========================================
+ Hits 4143 4147 +4
- Misses 1711 1715 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Nanoleaf bulb seems a lot more reliable now. No more failures to turn on because it timed out |
|
We are effectively side stepping this issue hbldh/bleak#927 as well since we only have to pay to to build that once now |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now cache the services when reconnecting to reduce the time before we can start talking to the accessory.
The cache is never used when we need to fetch the GATT database or the ble device has changed
between connections.
The naïve address check has been replaced with the
ble_device_has_changedhelper which knows aboutadapter changes.